-
Notifications
You must be signed in to change notification settings - Fork 536
conformance: add Hook in ConformanceTestSuite #3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/approve thanks ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg, zirain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this is okay, as it only runs after the test has been completed. It's super important that we don't allow hooks before, as we don't want the behavior of the conformance tests to be able to be modified (or else we can't be sure that the same behavior is executed for every implementation, defeating the point of conformance). I won't LGTM though, as I'd like @mlavacca to confirm he's okay with this. Holding for his review. /hold |
I want to clearify that, we want this to run dump function for debugging a flaky test. |
Thanks @zirain! /lgtm FYI @spencerhance @SinaChavoshi in case this is helpful on inference extension tests |
Missed this, will leave the hold in place for @mlavacca. |
What type of PR is this?
/kind feature
/kind test
/area conformance-test
What this PR does / why we need it:
Add hook points support in conformance test suite
Which issue(s) this PR fixes:
Fixes #3131
Does this PR introduce a user-facing change?: